* [#1966] refactor(ApacheMultipartParser): avoid declaring finalize() methods

** It makes GC work slower. GC puts all objects with "finalize" method to a separate "finalization queue", and GC collects them only during FullGC pause.

Author: asolntsev

framework/src/play/data/parsing/ApacheMultipartParser.java

@@ -437,17 +437,6 @@ public File getStoreLocation() {
         }
         // ------------------------------------------------------ Protected methods
 
-        /**
-         * Removes the file contents from the temporary storage.
-         */
-        protected void finalize() {
-            File outputFile = dfos.getFile();
-
-            if (outputFile != null && outputFile.exists()) {
-                outputFile.delete();
-            }
-        }
-
         /**
          * Creates and returns a {@link java.io.File File} representing a uniquely
          * named temporary file in the configured repository path. The lifetime of
@@ -525,37 +514,42 @@ public Map<String, String[]> parse(InputStream body) {
                 FileItemStream item = iter.next();
                 FileItem fileItem = new AutoFileItem(item);
                 try {
-                    Streams.copy(item.openStream(), fileItem.getOutputStream(), true);
-                } catch (FileUploadIOException e) {
-                    throw (FileUploadException) e.getCause();
-                } catch (IOException e) {
-                    throw new IOFileUploadException("Processing of " + MULTIPART_FORM_DATA + " request failed. " + e.getMessage(), e);
-                }
-                if (fileItem.isFormField()) {
-                    // must resolve encoding
-                    String _encoding = Request.current().encoding; // this is our default
-                    String _contentType = fileItem.getContentType();
-                    if( _contentType != null ) {
-                        HTTP.ContentTypeWithEncoding contentTypeEncoding = HTTP.parseContentType(_contentType);
-                        if( contentTypeEncoding.encoding != null ) {
-                            _encoding = contentTypeEncoding.encoding;
-                        }
+                    try {
+                        Streams.copy(item.openStream(), fileItem.getOutputStream(), true);
+                    } catch (FileUploadIOException e) {
+                        throw (FileUploadException) e.getCause();
+                    } catch (IOException e) {
+                        throw new IOFileUploadException("Processing of " + MULTIPART_FORM_DATA + " request failed. " + e.getMessage(), e);
                     }
+                    if (fileItem.isFormField()) {
+                        // must resolve encoding
+                        String _encoding = Request.current().encoding; // this is our default
+                        String _contentType = fileItem.getContentType();
+                        if( _contentType != null ) {
+                            HTTP.ContentTypeWithEncoding contentTypeEncoding = HTTP.parseContentType(_contentType);
+                            if( contentTypeEncoding.encoding != null ) {
+                                _encoding = contentTypeEncoding.encoding;
+                            }
+                        }
 
-                    putMapEntry(result, fileItem.getFieldName(), fileItem.getString( _encoding ));
-                } else {
-                    @SuppressWarnings("unchecked") List<Upload> uploads = (List<Upload>) Request.current().args.get("__UPLOADS");
-                    if (uploads == null) {
-                        uploads = new ArrayList<Upload>();
-                        Request.current().args.put("__UPLOADS", uploads);
-                    }
-                    try {
-                        uploads.add(new FileUpload(fileItem));
-                    } catch (Exception e) {
-                        // GAE does not support it, we try in memory
-                        uploads.add(new MemoryUpload(fileItem));
+                        putMapEntry(result, fileItem.getFieldName(), fileItem.getString( _encoding ));
+                    } else {
+                        @SuppressWarnings("unchecked") List<Upload> uploads = (List<Upload>) Request.current().args.get("__UPLOADS");
+                        if (uploads == null) {
+                            uploads = new ArrayList<Upload>();
+                            Request.current().args.put("__UPLOADS", uploads);
+                        }
+                        try {
+                            uploads.add(new FileUpload(fileItem));
+                        } catch (Exception e) {
+                            // GAE does not support it, we try in memory
+                            uploads.add(new MemoryUpload(fileItem));
+                        }
+                        putMapEntry(result, fileItem.getFieldName(), fileItem.getFieldName());
                     }
-                    putMapEntry(result, fileItem.getFieldName(), fileItem.getFieldName());
+                }
+                finally {
+                    fileItem.delete();
                 }
             }
         } catch (FileUploadIOException e) {