Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See gloot internals when saving branch as scene, or making local. #153

Open
LeeWannacott opened this issue Feb 8, 2024 · 3 comments
Open
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@LeeWannacott
Copy link
Contributor

LeeWannacott commented Feb 8, 2024

Hi,

Just curious, when saving a scene as a branch containing nodes from gloot, or "make local" a branch scene containing nodes from gloot; you can see the internal nodes. I don't know if it's supposed to be that way? or they are suppose to be hidden away from the user (like they are initially)?

Not really an issue per say... guess it could get cluttered if you have a ton of inventories

Cheers.

image

@peter-kish
Copy link
Owner

Yeah, this is unintentional and I'm not sure what I can do about it...

The UI controls of the plugin are naturally composed out of built-in controls and those usually don't show up in the editor scene tree, until you save the scene as a branch - so I guess Godot is somewhat inconsistent on how it treats them.
I could simply not create the child nodes when inside the editor (Engine.is_editor_hint()), but then the controls will not be rendered inside the editor at all, which is even worse.

Thanks for letting me know, I wasn't aware of this issue at all. I'll see if I can come up with some fix for this...

@peter-kish peter-kish added the bug Something isn't working label Feb 9, 2024
@peter-kish
Copy link
Owner

Good news: It's a known Godot issue that has been fixed in the meantime: godotengine/godot#82756
Bad news: Doesn't seem like it's not going to be released until Godot v4.3

@LeeWannacott
Copy link
Contributor Author

Not a big deal I guess, At least there is a work around just don't save as a branch, or make local 😅

Always waiting for godot 🤖

@peter-kish peter-kish added the wontfix This will not be worked on label Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants