Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay/Slowness when navigating #13

Open
khumphrey-sb opened this issue Jan 23, 2018 · 2 comments
Open

Delay/Slowness when navigating #13

khumphrey-sb opened this issue Jan 23, 2018 · 2 comments

Comments

@khumphrey-sb
Copy link

Steps to reproduce

  1. Implement react-navigation-is-focused-hoc
  2. use decorator @withNavigationFocus('MyControl')
  3. slowness/delay when navigating

Expected behaviour

Navigation should occur without delay.

Actual behaviour

There is a very noticeable delay between when the press happens and when the navigation action starts.

Environment

  • React Navigation version: "react-navigation": "^1.0.0-beta.22",
  • Node.js version: v8.9.1
  • React Native version: "react-native": "0.51.0",
  • React Native platform + platform version: iOS 9.0, Android 5.0, etc

iOS simulator 11.2, Android Pixel 2 simulator, iPhone 6 physical device running 11.2

react-navigation-is-focused-hoc

Version: "react-navigation-is-focused-hoc": "^1.1.1"

Commenting out updateFocus(currentState) in the onNavigationStateChange makes the delay go away.

I've currently only decorated two of my screen controls in a large existing app with HOC for testing. The events are working fine, but the delay after the press makes it a non starter. I can try to replicate using a smaller app but was wondering if anyone had seen this before.

@mikeduminy
Copy link

I'm also experiencing this problem.

@anasvemmully
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants