Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Config #107

Closed
lmittmann opened this issue May 23, 2023 · 4 comments
Closed

Nested Config #107

lmittmann opened this issue May 23, 2023 · 4 comments

Comments

@lmittmann
Copy link

Would you be open to a PR that enables nesting inside JSON configurations? This would allow flags containing dots to be looked up at the corresponding path. E.g. the flag a.b could be configured inside {"a": {"b":"xxx"}}.

@peterbourgon
Copy link
Owner

Probably not.

@lmittmann
Copy link
Author

This is possible with fftoml, why not allow it for json and yml?

@peterbourgon
Copy link
Owner

I think it may have been a mistake to allow it in fftoml.

But, upon reflection, I suspect my initial reaction may be too conservative, and there may be actual value in this feature.

I'm open to reviewing a change that allows nesting of configuration in this way, provided the API and behavior is consistent across ffyaml, fftoml, and ffjson.

@jolheiser
Copy link

This can be closed per #112

Thanks again to both of you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants