Skip to content

Commit 3bb39e8

Browse files
committed
Update ESLint no-require rule to no-require-in-service, use filename to scope rule check
1 parent 4315020 commit 3bb39e8

File tree

5 files changed

+3
-9
lines changed

5 files changed

+3
-9
lines changed

.eslintrc

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@
1414
"no-underscore-dangle": 0,
1515
"new-cap": 0,
1616
"dot-notation": 0,
17-
"no-require": 0
17+
"no-require-in-service": 2
1818
}
1919
}

eslint-rules/no-require.js eslint-rules/no-require-in-service.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
module.exports = function(context) {
22
return {
33
CallExpression: function(node) {
4+
if (!context.filename.match(/^lib\/services\//)) return;
45
if (node.callee.name === 'require' && node.arguments[0].value !== '../core') {
56
context.report(node, 'require() is disallowed in service files');
67
}

lib/services.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
/* eslint no-require:0 */
2-
31
var fs = require('fs');
42
var path = require('path');
53
var AWS = require('./core');

lib/services/.eslintrc

-5
This file was deleted.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"jasmine-node": "*",
1818
"semver": "*",
1919
"coffee-script": "1.6.3",
20-
"eslint": "*",
20+
"eslint": "git://github.com/lsegal/eslint#add-filename-to-rules",
2121
"cucumber": "*",
2222
"coffeeify": "*"
2323
},

0 commit comments

Comments
 (0)