Skip to content

Commit 5b77927

Browse files
committed
Add Buffer and jasmine references where necessary in tests
1 parent ac492f2 commit 5b77927

12 files changed

+21
-10
lines changed

test/event_emitter.spec.coffee

+2-2
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ describe 'AWS.EventEmitter', ->
5353

5454
describe 'addNamedListener', ->
5555
it 'defines a constant with the callback', ->
56-
spy = createSpy()
56+
spy = jasmine.createSpy()
5757
@emitter.addNamedListener('CONSTNAME', 'eventName', spy)
5858
expect(@emitter.CONSTNAME).toBe(spy)
5959

@@ -71,7 +71,7 @@ describe 'AWS.EventEmitter', ->
7171
expect(r).toBe(@emitter)
7272

7373
it 'provides an add function in callback to call addNamedListener', ->
74-
spy1 = createSpy(); spy2 = createSpy()
74+
spy1 = jasmine.createSpy(); spy2 = jasmine.createSpy()
7575
@emitter.addNamedListeners (add) ->
7676
add('CONST1', 'event1', spy1)
7777
add('CONST2', 'event2', spy2)

test/event_listeners.spec.coffee

+8-7
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
helpers = require('./helpers')
1515
AWS = helpers.AWS
1616
MockClient = helpers.MockClient
17+
Buffer = require('buffer').Buffer
1718

1819
describe 'AWS.EventListeners', ->
1920

@@ -36,10 +37,10 @@ describe 'AWS.EventListeners', ->
3637
client.config.credentials = AWS.util.copy(client.config.credentials)
3738

3839
# Helpful handlers
39-
successHandler = createSpy('success')
40-
errorHandler = createSpy('error')
41-
completeHandler = createSpy('complete')
42-
retryHandler = createSpy('retry')
40+
successHandler = jasmine.createSpy('success')
41+
errorHandler = jasmine.createSpy('error')
42+
completeHandler = jasmine.createSpy('complete')
43+
retryHandler = jasmine.createSpy('retry')
4344

4445
# Safely tear down setTimeout hack
4546
afterEach -> `setTimeout = oldSetTimeout`
@@ -67,7 +68,7 @@ describe 'AWS.EventListeners', ->
6768
expect(response.error).toEqual("ERROR")
6869

6970
it 'sends error event if credentials are not set', ->
70-
errorHandler = createSpy()
71+
errorHandler = jasmine.createSpy()
7172
request = makeRequest()
7273
request.on('error', errorHandler)
7374

@@ -182,7 +183,7 @@ describe 'AWS.EventListeners', ->
182183

183184
describe 'retry', ->
184185
it 'retries a request with a set maximum retries', ->
185-
sendHandler = createSpy('send')
186+
sendHandler = jasmine.createSpy('send')
186187
client.config.maxRetries = 10
187188

188189
# fail every request with a fake networking error
@@ -256,7 +257,7 @@ describe 'AWS.EventListeners', ->
256257

257258
it 'emits error if an error is set in extractError', ->
258259
error = code: 'ParseError', message: 'error message'
259-
extractDataHandler = createSpy('extractData')
260+
extractDataHandler = jasmine.createSpy('extractData')
260261

261262
helpers.mockHttpResponse 400, {}, ''
262263

test/helpers.coffee

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
AWS = require('../lib/aws')
1515
EventEmitter = require('events').EventEmitter
16+
Buffer = require('buffer').Buffer
1617

1718
# Mock credentials
1819
AWS.config.update

test/param_validator.spec.coffee

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
helpers = require('./helpers')
1515
AWS = helpers.AWS
16+
Buffer = require('buffer').Buffer
1617

1718
describe 'AWS.ParamValidator', ->
1819
[members, rules] = [{}, {}]

test/request.spec.coffee

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ helpers = require('./helpers')
1515
EventEmitter = require('events').EventEmitter
1616
AWS = helpers.AWS
1717
MockClient = helpers.MockClient
18+
Buffer = require('buffer').Buffer
1819

1920
describe 'AWS.Request', ->
2021
client = new MockClient

test/service_interface/json.spec.coffee

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
# language governing permissions and limitations under the License.
1313

1414
AWS = require('../../lib/core')
15+
Buffer = require('buffer').Buffer
1516
require('../../lib/service_interface/json')
1617

1718
describe 'AWS.ServiceInterface.Json', ->

test/service_interface/query.spec.coffee

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
# language governing permissions and limitations under the License.
1313

1414
AWS = require('../../lib/core')
15+
Buffer = require('buffer').Buffer
1516
require('../../lib/service_interface/query')
1617

1718
describe 'AWS.ServiceInterface.Query', ->

test/service_interface/rest_json.spec.coffee

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
# language governing permissions and limitations under the License.
1313

1414
helpers = require('../helpers'); AWS = helpers.AWS
15+
Buffer = require('buffer').Buffer
1516
require('../../lib/service_interface/rest_json')
1617

1718
describe 'AWS.ServiceInterface.RestJson', ->

test/service_interface/rest_xml.spec.coffee

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
# language governing permissions and limitations under the License.
1313

1414
helpers = require('../helpers'); AWS = helpers.AWS
15+
Buffer = require('buffer').Buffer
1516
require('../../lib/service_interface/rest_xml')
1617

1718
describe 'AWS.ServiceInterface.RestXml', ->

test/services/glacier.spec.coffee

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
helpers = require('../helpers')
1515
AWS = helpers.AWS
16+
Buffer = require('buffer').Buffer
1617

1718
require('../../lib/services/glacier')
1819

test/services/s3.spec.coffee

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
helpers = require('../helpers')
1515
AWS = helpers.AWS
1616
Stream = require('stream').Stream
17+
Buffer = require('buffer').Buffer
1718

1819
require('../../lib/services/s3')
1920

test/util.spec.coffee

+2-1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
# language governing permissions and limitations under the License.
1313

1414
AWS = require('../lib/core')
15+
Buffer = require('buffer').Buffer
1516

1617
describe 'uriEscape', ->
1718

@@ -319,7 +320,7 @@ describe 'AWS.util.inherit', ->
319320

320321
it 'should create pass-through constructor if not defined', ->
321322
Base = AWS.util.inherit
322-
constructor: createSpy()
323+
constructor: jasmine.createSpy()
323324

324325
Derived = AWS.util.inherit Base,
325326
other: true

0 commit comments

Comments
 (0)