Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please include support for a way to .tap only errors #755

Closed
hcldan opened this issue Sep 4, 2015 · 3 comments
Closed

Please include support for a way to .tap only errors #755

hcldan opened this issue Sep 4, 2015 · 3 comments

Comments

@hcldan
Copy link

hcldan commented Sep 4, 2015

I would love to have cleanup functions that would not require me to rethrow the error.

promise.tapcatch(function(error) {
   // clean up some stuff in scope
});

instead of

promise.catch(function(error) {
   // clean up some stuff in scope
   throw error;
});

low priority... would be nice to have.

@phpnode
Copy link

phpnode commented Sep 4, 2015

dupe of #589

@hcldan
Copy link
Author

hcldan commented Sep 4, 2015

Which is a dupe of #517... so I guess this isn't going in, huh?

@benjamingr
Copy link
Collaborator

As others have pointed out, this is a dupe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants