Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintanability: Remove deprecated io classes #607

Open
juarezr opened this issue Feb 6, 2022 · 0 comments
Open

Maintanability: Remove deprecated io classes #607

juarezr opened this issue Feb 6, 2022 · 0 comments
Labels
dependencies Pull requests that update a dependency file Help Wanted We are volunteers. We'll be happy if you join us. Maintainability Issues for code modernization, improve development, testing
Milestone

Comments

@juarezr
Copy link
Member

juarezr commented Feb 6, 2022

Context

  • After Petl use fsspec #494 landed in v1.6.0, petl started using fsspec for handling read and writing from/to remote servers and cloud filesystems.
  • Before there were some classes for dealing with compression and SMB.
  • But with fsspec they become duplicated code.
  • We have these choices for this code:
    • Remove it and require fsspec for this functionality
    • Make it private and use it as a fallback when one does not want to add a dependency to fsspec. So one need to make it clear in docs.
@juarezr juarezr added Maintainability Issues for code modernization, improve development, testing Help Wanted We are volunteers. We'll be happy if you join us. dependencies Pull requests that update a dependency file labels Feb 6, 2022
@juarezr juarezr added this to the v2.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Help Wanted We are volunteers. We'll be happy if you join us. Maintainability Issues for code modernization, improve development, testing
Projects
None yet
Development

No branches or pull requests

1 participant