Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support abi types for python 2.x #213

Closed
guoshimin opened this issue Mar 4, 2016 · 4 comments
Closed

Support abi types for python 2.x #213

guoshimin opened this issue Mar 4, 2016 · 4 comments

Comments

@guoshimin
Copy link

Currently pex only supports abi types like 'dmu' for python 3: https://github.com/pantsbuild/pex/blob/f5721a98f21dc680a0f541cede1afa724d2a4159/pex/pep425.py#L102

I built a numpy wheel on linux, and it has filename numpy-1.10.4-cp27-cp27mu-linux_x86_64.whl. Because there is no support for abi type mu for python 2.7, pex doesn't think it's a valid package for numpy on linux_x86_64.

@kwlzn
Copy link
Contributor

kwlzn commented Mar 10, 2016

confirming this is indeed an issue. repro:

[illuminati zzz]$ find deps -type f
deps/cryptography-1.2.3-cp27-cp27m-macosx_10_10_intel.whl
[illuminati zzz]$ pex --disable-cache --no-pypi -f ./deps cryptography==1.2.3 -v -v -v
pex: crawling link i=0 link=Link('file:///private/tmp/zzz/deps') follow_links=False                                    
Could not satisfy all requirements for cryptography==1.2.3:
    cryptography==1.2.3
[illuminati zzz]$ cp deps/cryptography-1.2.3-cp27-{cp27m,none}-macosx_10_10_intel.whl 
[illuminati zzz]$ pex --disable-cache --no-pypi -f ./deps cryptography==1.2.3 -v -v -v
pex: crawling link i=0 link=Link('file:///private/tmp/zzz/deps') follow_links=False                                    
pex: Building pex :: Resolving distributions :: Fetching file:///private/tmp/zzz/deps/cryptography-1.2.3-cp27-none-macospex: Building pex :: Resolving distributions :: Fetching file:///private/tmp/zzz/deps/cryptography-1.2.3-cp27-none-macospex: Building pex :: Resolving distributions :: Translating /private/var/folders/3t/xkwqrkld4xxgklk2s4n41jb80000gn/T/tmpCould not satisfy all requirements for enum34:10_intel.whl into distribution                                  
    enum34(from: cryptography==1.2.3)

@ewang
Copy link
Contributor

ewang commented Mar 11, 2016

I added a PR for this in #214. But not quite sure if the implementation is 100% accurate since I couldn't find much documentation online regarding py2.x ABI tags.

@kwlzn
Copy link
Contributor

kwlzn commented Mar 11, 2016

this should now be fixed in master (thanks @ewang!) - I'll get a pypi release cut ~tomorrow for general consumption.

can follow #215 for the release.

@kwlzn kwlzn closed this as completed Mar 11, 2016
@guoshimin
Copy link
Author

Awesome! Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants