Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Come up with a plan for installing wheels in pexes post wheel 0.31.1 #603

Closed
jsirois opened this issue Oct 16, 2018 · 3 comments
Closed

Comments

@jsirois
Copy link
Member

jsirois commented Oct 16, 2018

After 0.31.1 the wheel.WheelFile.install API we use here is gone:
https://github.com/pantsbuild/pex/blob/ac7aab86e90cfdff43e0b05c6a3500a6cb354547/pex/pex_builder.py#L279-L291

See pypa/wheel#262

@jsirois
Copy link
Member Author

jsirois commented Oct 16, 2018

The WheelFile.install code is not super involved even though it looks extensive at 1st glance:
https://github.com/pypa/wheel/blob/3dc261abc98a5e43bc7fcf5783d080aaf8f9f0cf/wheel/install.py#L275-L397

The answer may be to just buckle down and implement install ourselves.

@kwlzn
Copy link
Contributor

kwlzn commented Oct 20, 2018

The answer may be to just buckle down and implement install ourselves.

makes sense to me for now until pypa/wheel#262 manifests - or perhaps we could both fork and attempt to upstream that impl as contrib solution for pypa/wheel#262.

@jsirois
Copy link
Member Author

jsirois commented May 11, 2020

This was solved in Pex 2.0.0 by vendoring Pip and using it to perform installs in #788

@jsirois jsirois closed this as completed May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants