Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review utility of CookieDomain::NotPresent variant #12

Open
pfernie opened this issue May 23, 2017 · 0 comments
Open

Review utility of CookieDomain::NotPresent variant #12

pfernie opened this issue May 23, 2017 · 0 comments

Comments

@pfernie
Copy link
Owner

pfernie commented May 23, 2017

This variant was originally intended to disambiguate between an empty string Domain: value being specified (undefined behavior) and no Domain attribute being present on the source cookie. Within the store, however, such variants eventually end up being converted to the HostOnly case per the RFC.

Is their utility in retaining this distinction? As it stands, there is logic around this in CookieStore::insert() that basically assumes this is an invalid case (resulting in CookieError::UnspecifiedDomain). It may make sense to simplify by removing this particular variant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant