Revert "feat(FunctionT): Allow passing constants to t() (#3326197 by …

…Murz)"
pfrenssen · Jul 17, 2023 · a0b76c6 · a0b76c6
1 parent e79554b
commit a0b76c6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 14 deletions.
diff --git a/coder_sniffer/Drupal/Sniffs/Semantics/FunctionTSniff.php b/coder_sniffer/Drupal/Sniffs/Semantics/FunctionTSniff.php
@@ -75,10 +75,7 @@ public function processFunctionCall(
             return;
         }
 
-        if ($tokens[$argument['start']]['code'] !== T_CONSTANT_ENCAPSED_STRING
-            && $tokens[$argument['start']]['code'] !== T_STRING
-            && $tokens[$argument['start']]['code'] !== T_SELF
-        ) {
+        if ($tokens[$argument['start']]['code'] !== T_CONSTANT_ENCAPSED_STRING) {
             // Not a translatable string literal.
             $warning = 'Only string literals should be passed to t() where possible';
             $phpcsFile->addWarning($warning, $argument['start'], 'NotLiteralString');

diff --git a/tests/Drupal/Semantics/FunctionTUnitTest.inc b/tests/Drupal/Semantics/FunctionTUnitTest.inc
@@ -34,14 +34,4 @@ class Test {
     return new TranslationWrapper(' Do not start with a space');
   }
 
-  public function testConstants() {
-    // Using constants in t() should be allowed.
-    $x = t(self::FOO);
-  }
-
 }
-
-// Using constants in t() should be allowed.
-const FOO2 = 'bar2';
-$x = t(FOO2);
-$x = t(Test::FOO);