Skip to content
This repository was archived by the owner on Jun 27, 2020. It is now read-only.

JPEG recreated at each start #33

Closed
SR-G opened this issue Dec 30, 2017 · 2 comments
Closed

JPEG recreated at each start #33

SR-G opened this issue Dec 30, 2017 · 2 comments
Assignees

Comments

@SR-G
Copy link

SR-G commented Dec 30, 2017

Even when defining a data dir, thumbnails are always recreated.

Steps to reproduce :

  • start program with the --tempdir data/ flag
  • all books are indexed / thumbnails are created
  • stop the program, the log 2017/12/30 21:17:50 Not removing temp dir because dir already existed at start is dumped (quite expected)
  • data/ folder still contains all *.jpg
  • start the program again with the same command line / same --tempdir
  • everything is indexed again (maybe expected) but every single thumbnail is then also recreated (which takes quite some time with a lot of *.epub)

(a test like "if the corresponding cover and thumbbail jpeg are already available in the current tempdir, then don't recreate them" is probably missing)

With BookServer 3.0.4

@pgaskin
Copy link
Owner

pgaskin commented Dec 30, 2017

Thanks for reporting these issues!

As for caching, I forgot to add the check. Good catch.

@pgaskin
Copy link
Owner

pgaskin commented Dec 30, 2017

I have fixed this, and it will be included in the next release. As for performance, there is not any noticeable difference unless you have a large number of books.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants