Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for vue 3 #12 #170

Closed
leibale opened this issue Sep 21, 2020 · 7 comments
Closed

Support for vue 3 #12 #170

leibale opened this issue Sep 21, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@leibale
Copy link

leibale commented Sep 21, 2020

Hi,

What's the plan regarding support for Vue 3?

Thanks

@apclegacy
Copy link

apclegacy commented Oct 15, 2020

i'll create a fork and try to get the 'basic-vue-cli' example running in Vue 3.

@apclegacy
Copy link

After a couple of hours reading the Code i think migrating this project to work with vue 3 might not be possible right now.

Not all dependencies support vue3 yet. for instance:
The project is bundled with rollup, which uses the component-compiler-utils which do not support vue3 yet.

so i think the best thing to do is either wait or write a material wrapper for vue 3 from scratch.

i might be completely wrong.

@pgbross
Copy link
Owner

pgbross commented Oct 16, 2020

Hi,

I am working on the conversion to Vue 3 but there are some structural changes needed, not least because $listeners, $attrs, and componentInstances have all changed.

@pgbross pgbross added the enhancement New feature or request label Oct 19, 2020
@pgbross
Copy link
Owner

pgbross commented Nov 18, 2020

There is a beta version that uses Vue -3 available in the v-next branch and can be installed with npm install vue-material-adapter@next. (it also uses material-components-web v8)

So far it is the existing components updated to handle the changes required by the two underlying libraries. It will be updated to add the new material-components-web components in due course.

@besingamkb
Copy link

hi im trying the vue3 with vue-material-adapter@next but its not working on my end.

Screenshot from 2020-12-04 00-41-11

@pgbross
Copy link
Owner

pgbross commented Dec 3, 2020

Looks like there is a peer dependency there for the old version of vue - it must have been left over from the previous version and I haven't had that issue (I am using it in Node 15 with NPM 6.14.9). When I use npm v7 I get the same error - presumably because the latest npm tries to install peer dependencies when earlier versions left it up to the user.

I will updatre the old peer dependency and make a new build to see if that fixes things.

@pgbross
Copy link
Owner

pgbross commented Dec 3, 2020

Ok the latest version (1.0.0-beta.13) now installs for me when using npm >=v7.

@pgbross pgbross closed this as completed Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants