Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

through2 still used in lib/log-reporter.js, but removed from package.json #205

Closed
TruffeCendree opened this issue Mar 3, 2022 · 4 comments
Closed

through2 still used in lib/log-reporter.js, but removed from package.json #205

TruffeCendree opened this issue Mar 3, 2022 · 4 comments

Comments

@TruffeCendree
Copy link

Thanks for managing this package.

We are unable to switch to v6.0.1 because the through2 dependency was removed from package.json, but is still used in lib/log-reporter.js.
@pioug pioug mentioned this issue Mar 3, 2022
Merged
@pioug
Copy link
Collaborator

pioug commented Mar 3, 2022

@TruffeCendree Hello, thanks for reporting this ! Can you test the PR #206 ? I've never used the reporter and it's not covered with tests 💦

@TruffeCendree
Copy link
Author

I will test it tomorrow.

@TruffeCendree
Copy link
Author

I was able to deploy by using your PR. Thanks.

@pioug
Copy link
Collaborator

pioug commented Mar 4, 2022

https://github.com/pgherveou/gulp-awspublish/releases/tag/v6.0.2

@pioug pioug closed this as completed Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pioug @TruffeCendree