Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum Contig Size for MOB-recon? #101

Closed
schorlton opened this issue Feb 28, 2022 · 3 comments
Closed

Maximum Contig Size for MOB-recon? #101

schorlton opened this issue Feb 28, 2022 · 3 comments

Comments

@schorlton
Copy link

schorlton commented Feb 28, 2022

Thanks for the great software! I'm wondering if the --max_contig_size param is implemented?

parser.add_argument('--max_contig_size', type=int, required=False,
help='Maximum size of a contig to be considered a plasmid',
default=310000)

I couldn't find it in the code if so. Just hit a case where we classified a complete circular 1+Mb bacterial genome as a novel plasmid. Thanks!

Addendum: also wondering about --max_plasmid_size (couldn't find it either):

parser.add_argument('--max_plasmid_size', type=int, required=False,
help='Maximum size of a reconstructed plasmid',
default=350000)

@jrober84
Copy link
Collaborator

Thanks for pointing that out, yes both of those options were orphaned in the update, I have added back in their functionality as quality checks and they will be available in the new version. Very cool you are finding plasmids that size, I know Borellia can have large plasmids nearing that size.

@schorlton
Copy link
Author

Thanks!
*should not be finding plasmids that size - as per issue "we classified a complete circular 1+Mb bacterial genome as a novel plasmid" and I want to avoid this with the max size parameter!

@jrober84
Copy link
Collaborator

Ah ok, understood!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants