[BUG]: Messages object not present in $form->isValid() with validation events

[raicabogdan]

Describe the bug
When using $form->isValid() to validate form and you have a validation class with beforeValidation() method, you get error:
Trying to call method count on a non-object

To Reproduce
Steps to reproduce the behavior:
As per documentation https://docs.phalcon.io/5.8/filter-validation/#events

class LoginValidation extends Validation
{
    public function initialize()
    {
        // ...
    }

    public function beforeValidation($data, $entity, $messages)
    {
        if ($this->request->getHttpHost() !== 'admin.mydomain.com') {
            $messages->appendMessage(
                new Message(
                    'Only users can log on in the admin domain'
                )
            );

            return false;
        }

        return true;
    }
}

Details

• Phalcon version: 5.8
• PHP Version: php 8.3

Additional context
The issue starts from $form->isValid() when validation->validate(data, entity); is being called

cphalcon/phalcon/Forms/Form.zep

Lines 719 to 723 in 83677f1

	/**
	* Perform the validation
	*/
	let messages = validation->validate(data, entity);
	if messages->count() {

and expects back a Phalcon\Messages object.

In the Phalcon\Filter\Validation class, in the validate() method, the messages variable is getting passed along to event beforeValidation and once the status returned from validate() is false (as per documentation), the messages do not get returned back.

cphalcon/phalcon/Filter/Validation.zep

Lines 501 to 521 in 83677f1

	/**
	* Implicitly creates a Phalcon\Messages\Messages object
	*/
	let messages = new Messages();
	if entity !== null {
	this->setEntity(entity);
	}
	/**
	* Validation classes can implement the 'beforeValidation' callback
	*/
	if method_exists(this, "beforeValidation") {
	let status = this->{"beforeValidation"}(data, entity, messages);
	if status === false {
	return status;
	}
	}
	let this->messages = messages;

Not entirely sure but, is it not possible to do something along the lines

// Phalcon\Forms\Form
        /**
        * Perform the validation
        */
        let result = validation->validate(data, entity);
        if result === false {
            let messages = validation->getMessages();
        } else {
            let messages = result;
        }
        
        if messages->count() {
            // Add validation messages to relevant elements
            for elementMessage in iterator(messages) {
                this->get(elementMessage->getField())->appendMessage(elementMessage);
            }

            messages->rewind();

            let validationStatus = false;
        }

and also

// Phalcon\Filter\Validation
         /** 
          * Implicitly creates a Phalcon\Messages\Messages object 
          */ 
         let this->messages = new Messages(); 
  
         if entity !== null { 
             this->setEntity(entity); 
         } 
  
         /** 
          * Validation classes can implement the 'beforeValidation' callback 
          */ 
         if method_exists(this, "beforeValidation") { 
             let status = this->{"beforeValidation"}(data, entity); 
  
             if status === false { 
                 return status; 
             } 
         }

and use this->appendMessage() in the event method instead.

[niden]

Resolved in #16704

Thank you @raicabogdan