MM optimizations

[ghost]

• grow should be 0 when MM is not used
• do not use MM if no memory allocation takes place

[phalcon]

Well, this could lead to some errors, when a method fails it tries to restore the memory stack automatically so what could happens is that it eventually will restore the wrong memory frame (a one created before) or produce a segfault if none is available

[ghost]

OK, I see, let me update the code

[ghost]

OK, what do you think about this: all the cases above are for forwarding methods, e.g.,

PHP_METHOD(Phalcon_DI, offsetSet){

    zval *name, *definition;

    phalcon_fetch_params(0, 2, 0, &name, &definition);

    phalcon_call_method_p2_noret(this_ptr, "setshared", name, definition);
}

basically the method is equivalent to

public function offsetSet($name, $definition)
{
    $this->setShared($name, $definition);
}

and offers only yet another level of indirection.

The idea is to use PHP_MALIAS() for such methods:

PHP_ME(Phalcon_DI, setShared, arginfo_phalcon_di_setshared, ZEND_ACC_PUBLIC)
PHP_MALIAS(Phalcon_DI, offsetSet, setShared, arginfo_phalcon_di_setshared, ZEND_ACC_PUBLIC)

Zend will create both methods (any of them can be overridden by the descendants if necessary) but they will share the same implementation.

The advantage is that offsetSet() will be as fast as setShared() (no overhead for the call to the userland and no need to allocate a memory frame).

For the developers we may add something like:

/**
 * @brief This method is an alias for Phalcon\Di::setShared()
 * @see setShared()
 */
PHALCON_DOC_METHOD(Phalcon_Di, offsetSet);

What do you think?

[phalcon]

Looks great!

[ghost]

Done.