Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incubator doesn't support phpunit 8 #888

Closed
d0niek opened this issue Feb 6, 2019 · 3 comments
Closed

Incubator doesn't support phpunit 8 #888

d0niek opened this issue Feb 6, 2019 · 3 comments

Comments

@d0niek
Copy link

d0niek commented Feb 6, 2019

It looks like incubator doesn't support phpunit 8

edium@aee089db38f6:/app$ bin/phpunit 
PHP Fatal error:  Declaration of Phalcon\Test\PHPUnit\UnitTestCase::setUp() must be compatible with PHPUnit\Framework\TestCase::setUp(): void in /app/vendor/phalcon/incubator/Library/Phalcon/Test/PHPUnit/UnitTestCase.php on line 31
PHP Stack trace:
PHP   1. {main}() /app/vendor/phpunit/phpunit/phpunit:0
PHP   2. PHPUnit\TextUI\Command::main() /app/vendor/phpunit/phpunit/phpunit:61
PHP   3. PHPUnit\TextUI\Command->run() /app/vendor/phpunit/phpunit/src/TextUI/Command.php:164
PHP   4. PHPUnit\TextUI\Command->handleArguments() /app/vendor/phpunit/phpunit/src/TextUI/Command.php:175
PHP   5. PHPUnit\Util\Configuration->getTestSuiteConfiguration() /app/vendor/phpunit/phpunit/src/TextUI/Command.php:910
PHP   6. PHPUnit\Util\Configuration->getTestSuite() /app/vendor/phpunit/phpunit/src/Util/Configuration.php:870
PHP   7. PHPUnit\Framework\TestSuite->addTestFiles() /app/vendor/phpunit/phpunit/src/Util/Configuration.php:1013
PHP   8. PHPUnit\Framework\TestSuite->addTestFile() /app/vendor/phpunit/phpunit/src/Framework/TestSuite.php:625
PHP   9. PHPUnit\Util\FileLoader::checkAndLoad() /app/vendor/phpunit/phpunit/src/Framework/TestSuite.php:546
PHP  10. PHPUnit\Util\FileLoader::load() /app/vendor/phpunit/phpunit/src/Util/FileLoader.php:45
PHP  11. include_once() /app/vendor/phpunit/phpunit/src/Util/FileLoader.php:57
PHP  12. spl_autoload_call() /app/tests/Controller/BaseControllerTest.php:14
PHP  13. Composer\Autoload\ClassLoader->loadClass() /app/tests/Controller/BaseControllerTest.php:14
PHP  14. Composer\Autoload\includeFile() /app/vendor/composer/ClassLoader.php:322
PHP  15. include() /app/vendor/composer/ClassLoader.php:444
PHP  16. spl_autoload_call() /app/tests/UnitTestCase.php:25
PHP  17. Composer\Autoload\ClassLoader->loadClass() /app/tests/UnitTestCase.php:25
PHP  18. Composer\Autoload\includeFile() /app/vendor/composer/ClassLoader.php:322
PHP  19. include() /app/vendor/composer/ClassLoader.php:444
PHP  20. spl_autoload_call() /app/vendor/phalcon/incubator/Library/Phalcon/Test/UnitTestCase.php:29
PHP  21. Composer\Autoload\ClassLoader->loadClass() /app/vendor/phalcon/incubator/Library/Phalcon/Test/UnitTestCase.php:29
PHP  22. Composer\Autoload\includeFile() /app/vendor/composer/ClassLoader.php:322
PHP  23. include() /app/vendor/composer/ClassLoader.php:444

Fatal error: Declaration of Phalcon\Test\PHPUnit\UnitTestCase::setUp() must be compatible with PHPUnit\Framework\TestCase::setUp(): void in /app/vendor/phalcon/incubator/Library/Phalcon/Test/PHPUnit/UnitTestCase.php on line 31

Call Stack:
    0.0008     392576   1. {main}() /app/vendor/phpunit/phpunit/phpunit:0
    0.0259    1731536   2. PHPUnit\TextUI\Command::main() /app/vendor/phpunit/phpunit/phpunit:61
    0.0260    1731648   3. PHPUnit\TextUI\Command->run() /app/vendor/phpunit/phpunit/src/TextUI/Command.php:164
    0.0260    1731648   4. PHPUnit\TextUI\Command->handleArguments() /app/vendor/phpunit/phpunit/src/TextUI/Command.php:175
    0.0428    2124712   5. PHPUnit\Util\Configuration->getTestSuiteConfiguration() /app/vendor/phpunit/phpunit/src/TextUI/Command.php:910
    0.0429    2125296   6. PHPUnit\Util\Configuration->getTestSuite() /app/vendor/phpunit/phpunit/src/Util/Configuration.php:870
    0.0550    2367592   7. PHPUnit\Framework\TestSuite->addTestFiles() /app/vendor/phpunit/phpunit/src/Util/Configuration.php:1013
    0.0550    2367592   8. PHPUnit\Framework\TestSuite->addTestFile() /app/vendor/phpunit/phpunit/src/Framework/TestSuite.php:625
    0.0550    2367592   9. PHPUnit\Util\FileLoader::checkAndLoad() /app/vendor/phpunit/phpunit/src/Framework/TestSuite.php:546
    0.0551    2367784  10. PHPUnit\Util\FileLoader::load() /app/vendor/phpunit/phpunit/src/Util/FileLoader.php:45
    0.0559    2383592  11. include_once('/app/tests/Controller/BaseControllerTest.php') /app/vendor/phpunit/phpunit/src/Util/FileLoader.php:57
    0.0559    2383592  12. spl_autoload_call() /app/tests/Controller/BaseControllerTest.php:14
    0.0559    2383640  13. Composer\Autoload\ClassLoader->loadClass() /app/tests/Controller/BaseControllerTest.php:14
    0.0560    2383720  14. Composer\Autoload\includeFile() /app/vendor/composer/ClassLoader.php:322
    0.0569    2418544  15. include('/app/tests/UnitTestCase.php') /app/vendor/composer/ClassLoader.php:444
    0.0569    2418544  16. spl_autoload_call() /app/tests/UnitTestCase.php:25
    0.0569    2418600  17. Composer\Autoload\ClassLoader->loadClass() /app/tests/UnitTestCase.php:25
    0.0569    2418712  18. Composer\Autoload\includeFile() /app/vendor/composer/ClassLoader.php:322
    0.0571    2419736  19. include('/app/vendor/phalcon/incubator/Library/Phalcon/Test/UnitTestCase.php') /app/vendor/composer/ClassLoader.php:444
    0.0571    2419736  20. spl_autoload_call() /app/vendor/phalcon/incubator/Library/Phalcon/Test/UnitTestCase.php:29
    0.0571    2419800  21. Composer\Autoload\ClassLoader->loadClass() /app/vendor/phalcon/incubator/Library/Phalcon/Test/UnitTestCase.php:29
    0.0571    2419912  22. Composer\Autoload\includeFile() /app/vendor/composer/ClassLoader.php:322
    0.0572    2422528  23. include('/app/vendor/phalcon/incubator/Library/Phalcon/Test/PHPUnit/UnitTestCase.php') /app/vendor/composer/ClassLoader.php:444

Details

  • Phalcon Framework version: 3.4.1
  • Phalcon Incubator version: v3.4.3
  • PHP Version: 7.2.14
@ruudboon
Copy link
Member

ruudboon commented Jul 28, 2019

For v4 I've upgraded to phpunit 7. For v8 I'm waiting for this one. Codeception/Specify#46

@Jeckerson Jeckerson added this to the 4.0.0 milestone Oct 9, 2019
@Jeckerson
Copy link
Member

Jeckerson commented Apr 12, 2020

Blocked by #911

@Jeckerson
Copy link
Member

Fixed as now each component has own repository.

@niden niden moved this from Backlog to Unverified - Wont Fix - Duplicates in Phalcon v5 Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Unverified - Wont Fix - Duplicates
Development

No branches or pull requests

3 participants