Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generating migration for Postgres does not create indexes #118

Closed
MaksymLevenets opened this issue Jun 8, 2021 · 2 comments
Closed

generating migration for Postgres does not create indexes #118

MaksymLevenets opened this issue Jun 8, 2021 · 2 comments
Assignees
@BeMySlaveDarlin
Labels
bug Something isn't working
Milestone
2.2.x

Comments

@MaksymLevenets
Copy link

MaksymLevenets commented Jun 8, 2021 •
edited
Loading

migrations/src/Migration/Action/Generate.php

Line 280 in fec5c23

if ($this->adapter !== Migration::DB_ADAPTER_POSTGRESQL && $column !== $this->getPrimaryColumnName()) {

This part always skip index column if postgres adapter used.
@Jeckerson Jeckerson added this to the 2.1.x milestone Aug 2, 2021
@BeMySlaveDarlin
Copy link
Contributor

Fixed in PR #120

@Jeckerson Jeckerson modified the milestones: 2.1.x, 2.2.x Aug 4, 2021
@Jeckerson
Copy link
Member

Jeckerson commented Aug 8, 2021 •
edited
Loading

Released in https://github.com/phalcon/migrations/releases/tag/v2.2.1

@Jeckerson Jeckerson added the bug Something isn't working label Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BeMySlaveDarlin BeMySlaveDarlin

Labels
bug Something isn't working
Projects
None yet
Milestone
2.2.x
Development

No branches or pull requests
3 participants
@Jeckerson @BeMySlaveDarlin @MaksymLevenets