Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new films #108

Open
rohittm opened this issue Apr 24, 2018 · 3 comments
Open

Adding new films #108

rohittm opened this issue Apr 24, 2018 · 3 comments

Comments

@rohittm
Copy link

rohittm commented Apr 24, 2018

I guess, new films (Rogue One, The Last Jedi, and Solo), Needs to be added to the list 😅

@phalt
Copy link
Owner

phalt commented May 1, 2018

As I've been saying for a few years now - happy to accept PRs with this data 😆

But I will make one judgement - SWAPI will only have the main series films (numbered movies), not anthology films.

@ajwallacemusic
Copy link

@phalt Is the fixtures folder where we would create a pull request with data? I'm noticing that the live site has data for 7 but the source code here doesn't, wondering what your db structure is.

@Willshaw
Copy link

This is great, I'll be sure to get contributing asap. Well done Phalt, you've made my day.

Is all the data held in this static json?
https://github.com/phalt/swapi/tree/master/resources/fixtures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants