Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path to stable Rust #16

Open
phansch opened this issue Oct 25, 2018 · 0 comments
Open

Path to stable Rust #16

phansch opened this issue Oct 25, 2018 · 0 comments
Labels
good first issue Good for newcomers

Comments

@phansch
Copy link
Owner

phansch commented Oct 25, 2018 •
edited
Loading

This should work once the 2018 edition is on stable (Rust 1.31).

We only use the uniform_paths feature.

Required steps once the 2018 edition is out:

  1. In rust-toolchain file change nightly to stable
  2. Remove the #![feature(uniform_paths)] in main.rs and lib.rs
  3. Make sure that the tests still pass locally
  4. Change nightly to stable here
  5. Open a PR with the changes
@phansch phansch added the good first issue Good for newcomers label Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phansch