Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide sha1 signed phar #30

Closed
glensc opened this issue Jan 27, 2016 · 2 comments
Closed

provide sha1 signed phar #30

glensc opened this issue Jan 27, 2016 · 2 comments
Labels

Comments

@glensc
Copy link

glensc commented Jan 27, 2016

please consider providing sha1 signed phar to avoid such errors:

[/tmp] ➔ phive.phar 
PHP Fatal error:  Uncaught exception 'PharException' with message 'phar "/home/glen/Dropbox/bin/phive.phar" has a unsupported signature' in /home/glen/Dropbox/bin/phive.phar:102
Stack trace:
#0 /home/glen/Dropbox/bin/phive.phar(102): Phar::mapPhar('phive.phar')
#1 {main}
  thrown in /home/glen/Dropbox/bin/phive.phar on line 102

please see if you can also build more compatible phar file:
sebastianbergmann/phpunit#1948 (comment)
sebastianbergmann/phpunit#1948 (comment)
sebastianbergmann/phpunit@4ef58ab

@theseer
Copy link
Member

theseer commented Jan 27, 2016

I'm not convinced that is a good idea. While we technically of course could provide a sha1 version of the next milestone release this won't solve the underlying issue for the phars phive is attempting to install. We thus would have to bail out in case we run into the missing support. Not exactly a nice solution.

To me the problem is actually in the PHP build shipping with PLD and potentially derivatives as all other tested distributions seem to compile PHP in a way that SHA256/SHA512 are available. While I do agree the compile time decision is broken and should be considered a bug within PHP itself, the build provided by PLD is the problem and should get adjusted.

@theseer
Copy link
Member

theseer commented Jan 27, 2016

Not to mention that falling back to outdated hashing algorithms is not exactly a favorable solution to begin with.

@theseer theseer removed their assignment Jan 28, 2016
@theseer theseer closed this as completed Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants