Removing a Key doesn't remove capturing from KeyboardPlugin

[cyantree]

Version

• Phaser Version: 3.54.0

• Operating system: Win 10 Pro 20H2

• Browser:

Description

After registering a key (a letter for example) with capturing enabled Phaser correctly captures the input events. This leads to not being able to type the letter in an input box outside of phaser. This is correct and expected.
However when removing this key, the capturing continues and therefore it still isn't possible to type the letter somewhere outside of Phaser.

I would expect that removing the last registration of a specific key also ends the capturing.
My current workaround is to trigger removeCapture() manually.

Example Test Code

// Register key with capturing enabled by default
const key = scene.input.keyboard.addKey(keyCode);

// Removing the key
scene.input.keyboard.removeKey(key, true);

// Afterwards I still can't use it outside of Phaser

// Removing the capture manually fixes the issue
scene.input.keyboard.removeCapture(key.keyCode);

Additional Information

I would expect that removing the last registration of a specific key also ends the capturing.

I think triggering removeCapture() manually is a workaround because in this case I have to keep track of all Key objects listening to the specific key code.

[samme]

The docs are pretty clear on this, though.

[cyantree]

The docs are pretty clear on this, though.

Could you give me a hint? I read through some pages and didn't find anything obvious regarding this behaviour.

[samme]

Sorry, I mean you're doing the right thing, according to the docs. 😃 You have to remove captures manually.

Key captures are global, and they're not really related to Key objects, even though addKey() kind of makes it look that way.

I guess automatically removing captures would be possible. The Input Manager would have to check the registered Keys in each scene.

[photonstorm]

Thank you for submitting this feature request. We have implemented this and the feature has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.