Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: GetLast function not implemented correctly #6513

Closed
dmokel opened this issue May 28, 2023 · 3 comments
Closed

Error: GetLast function not implemented correctly #6513

dmokel opened this issue May 28, 2023 · 3 comments

Comments

@dmokel
Copy link
Contributor

dmokel commented May 28, 2023

Version

  • Phaser Version: v3.60.0
  • Operating system: macOS Monterey
  • Browser: Chrome

Description

From a semantic perspective, the GetFirst method returns the first element in the array that has properties which match all of those specified in the compare object and the GetLast method returns the last element in the array that has properties which match all of those specified in the compare object. But their source codes are the same now.

The GetLast function code is incorrect.
image
image

Example Test Code

Additional Information

@Arunabh-gupta
Copy link

Hey is anyone working on this issue?? If not can you assign it to me??

@rexrainbow
Copy link
Contributor

@Arunabh-gupta Already PR by author of this thread

@photonstorm
Copy link
Collaborator

Thanks for opening this issue, and for submitting a PR to fix it. We have merged your PR into the master branch and attributed the work to you in the Change Log. If you need to tweak the code for whatever reason please submit a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants