Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated Entities Should Not Copy Internal Properties #33

Open
3 tasks
ahives opened this issue Aug 8, 2017 · 3 comments
Open
3 tasks

Translated Entities Should Not Copy Internal Properties #33

ahives opened this issue Aug 8, 2017 · 3 comments

Comments

@ahives
Copy link
Contributor

ahives commented Aug 8, 2017

When an entity is translated, there are values which should not be copied from the original entity, but instead, set to the values which are set on a new entity.

The following properties should be Set instead of copied:

  • Id
  • IsEmpty
  • Values

Will also need the ability to obtain the TextSlice from the values, in order, based upon the schema, to fill the Fields. This will likely get more real once the formatter work is completed.

@phatboyg phatboyg changed the title Translator unit tests are failing with latest commit Translated Entities Should Not Copy Internal Properties Aug 10, 2017
@phatboyg
Copy link
Owner

Still haven't done this yet.

@ahives
Copy link
Contributor Author

ahives commented Dec 7, 2017

@phatboyg Is this still valid?

@phatboyg
Copy link
Owner

phatboyg commented Dec 7, 2017

Yeah, I don't have the work finished yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants