Do not use HL7MessageParser in non-streaming scenario

[ahives]

Currently the HL7MessageParser is being used in the non-streaming scenario and we do not enforce the parser blowing up if there is no MSH segment. Below is the conversation we had on a recent PR:

phatboyg commented 4 days ago
But this is for parsing a stream of messages, right?
It should just return Unmatched after the first matching message, instead of throwing an exception.

ahives commented 4 days ago • edited
Hmm, you are partially correct. It gets called for both and maybe that is the problem. For stream this might be bad but the question is that for stream parsing do we retain knowledge of the delimiters? If we do then it is a useless check for both, which means we probably should just hard code the delimiters.

ahives commented 4 days ago
That said, if I have a malformed message that was discovered on the first read then why would I want to continue parsing? Moreover, why would that be considered a successful parse if I find the data I am looking for downstream on a malformed message?