Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relation graphs #125

Open
balhoff opened this issue Sep 9, 2019 · 2 comments · Fixed by #198
Open

Add relation graphs #125

balhoff opened this issue Sep 9, 2019 · 2 comments · Fixed by #198
Assignees
Labels
enhancement New feature or request

Comments

@balhoff
Copy link
Member

balhoff commented Sep 9, 2019

It would be useful to compute existential relation graphs for the core bio-ontologies. Some background is here: https://github.com/NCI-Thesaurus/thesaurus-obo-edition/wiki/NCIt-graph-queries

I have a little badly documented tool for computing this: https://github.com/NCI-Thesaurus/ncit-utils

Here's an example: https://github.com/NCATS-Tangerine/ubergraph/blob/e3da8808db424f2009944b54f0c04d5aacac0eb7/Makefile#L25-L29

@balhoff
Copy link
Member Author

balhoff commented Aug 14, 2020

At the same time, we should remove generation of DOS-DP-based "property classes", e.g.

pipeline/Makefile

Lines 268 to 276 in ebcb7be

$(BUILD_DIR)/anatomical-entity-partOf.ofn: $(BUILD_DIR)/anatomical-entities.txt patterns/part_of.yaml
mkdir -p $(dir $@) \
&& dosdp-tools generate \
--generate-defined-class=true \
--obo-prefixes=true \
--template=patterns/part_of.yaml \
--infile=$< \
--outfile=$@.tmp \
&& mv $@.tmp $@

We don't want to include these in the output.

However, we do want tbox classes from Phenoscape data (NeXML files).

@balhoff
Copy link
Member Author

balhoff commented Aug 19, 2020

Something we need to make sure we do before closing this issue:

  • Update presence/absence queries to use the relation graphs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants