-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Term suggestion shows error popup #2
Comments
alternative sources of terminology |
I may have capacity to look at this bug in the near future - please let me know if this has any particular requirements from your part :) |
Does the fork https://github.com/aehrc/open-pedigree address this? New disorders can be added with their changes, awesome stuff! Perhaps we could ask @dconlan for a pull request or incorporate the changes here |
I am working on a a pull request with my changes for terminology fetching. I'm not happy with the forced inclusion of the FHIR specific 'system' which goes along with the code. In the FHIR world, a codeable concept needs a system and a code, where the system tells you the code system the code is from. My GA4GH FHIR format pull included an object specifically for letting the converter know what systems to use, which seemed like a better solution then forcing the code that does the webservice call to fetch the codes to know about a system when its only relevant if they are doing a query on a fhir terminology server. |
The term suggestion is broken because of the lack of a configurable terminology server.
When a terminology server is not present, terms should just be added as plaintext, rather than throwing an error.
The text was updated successfully, but these errors were encountered: