-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
best time is not shown on level-selection screen #173
Comments
Assigning to @ariel-phet to decide if this should be added. I believe it would be fairly easy, but since it wasn't in the design I thought we should discuss. He is welcome to assign to @amanda-phet if he'd like. I'm also assuming that, even if fixed, this wouldn't warrant a maintenance release and would just go out the next time the sim is republished from the master branch. This could potentially be a while, so we should be clear about that too. #172 has been addressed, so it should be easier to test this if running from master. |
at developer meeting we discussed this being consistent, so yes it seems if the timer is on, and you get a perfect score best time should be displayed. This is low priority, and can be done as a maintenance release sometime. |
It seems this might be straightforward and could be addressed in the upcoming region and character publication. Adding to the project board. |
I agree this can be addressed with the re-publication. |
We have decided to not show time on any LevelSelectionScreens moving forward. |
Discussed in phetsims/vegas#51 (comment) and we decided not to show times on level selection screens moving forward. |
Based on the meeting decision above, this issue can be closed. |
This sim apparently keeps track of the best time for perfect scores (a little difficult to test because of #172). Why is the best time not shown under the buttons on the level-selection screen? Keeping track of best time isn't very useful if you can't see what your best time was on the level-selection screen. And other sims that track best time (search for 'bestTimeProperty') display it on the level-selection screen, so this is inconsistent.
The text was updated successfully, but these errors were encountered: