Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make 'adapted-from-phet' the default brand #19

Closed
pixelzoom opened this issue Jul 16, 2015 · 6 comments
Closed

make 'adapted-from-phet' the default brand #19

pixelzoom opened this issue Jul 16, 2015 · 6 comments
Assignees
@pixelzoom

Comments

@pixelzoom
Copy link
Contributor

Broke this issue out of #13.

Until all brands are in master, this means moving the 'adapted-from-phet' branch to master.
@pixelzoom pixelzoom changed the title move 'adapted-from-phet' the default brand make 'adapted-from-phet' the default brand Jul 16, 2015
@samreid
Copy link
Member

samreid commented Jul 16, 2015

@pixelzoom is this complete?

@pixelzoom
Copy link
Contributor Author

No, hasn't been done. Was potentially waiting until all brands are in master. And doesn't need to be addressed for S2015R.

@samreid
Copy link
Member

samreid commented Aug 3, 2015

I'll be working on some other branding issue in the near future, so I'll assign this to me and take a look at it as well.

@samreid samreid assigned samreid and unassigned pixelzoom Aug 3, 2015
@samreid samreid mentioned this issue Aug 3, 2015
Closed
@samreid
Copy link
Member

samreid commented Aug 4, 2015

adapted-from-phet is now the default brand, and can be overriden with a grunt option --brand or a query parameter ?brand

Closing.

@samreid samreid closed this as completed Aug 4, 2015
@pixelzoom
Copy link
Contributor Author

Reopening.

Did we bail on being able to specify the brand in $HOME/.phet/build-local.properties ?

@pixelzoom pixelzoom reopened this Aug 4, 2015
@samreid
Copy link
Member

samreid commented Aug 4, 2015

We did not bail on being able to specify the brand in $HOME/.phet/build-local.json, it is being tracked and labeled for discussion at the next developer meeting in #11

Please close if there is nothing else to do for this issue.

@samreid samreid assigned pixelzoom and unassigned samreid Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @pixelzoom