Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center and Variability Postmortem #597

Closed
5 of 9 tasks
marlitas opened this issue Nov 1, 2023 · 6 comments
Closed
5 of 9 tasks

Center and Variability Postmortem #597

marlitas opened this issue Nov 1, 2023 · 6 comments
Assignees

Comments

@marlitas
Copy link
Contributor

marlitas commented Nov 1, 2023

Center and Variability postmortem

  • 1. Schedule the meeting Tuesday, November 14th 11:00-12:00 MT

  • Invite the entire sim team to participate, and optionally anyone else who had a significant involvement. Have the
    meeting as soon as possible after the sim is released, so that experiences are still fresh in everyone's mind. Allow
    sufficient time for the meeting, 1.5-2 hours.

  • 2. Enlist a meeting moderator @arouinfar

  • The moderator's job is to make sure the meeting runs efficiently, stays on point, and focuses on constructive (but not
    overly negative) criticism. The moderator can be someone not on the sim team, or in many cases the Development
    Coordinator. The moderator also documents the important points of the meeting.

  • 3. Create github postmortem issue and postmortem google doc

  • Create a GitHub issue in the repository of the sim for which the postmortem is occurring. This checklist will should
    be copied into the issue.

  • Create a postmortem Google doc for the sim and set phethelp as the owner. This Google doc should live within the
    appropriate sim folder on Google drive
    https://docs.google.com/document/d/1Otq41pw1Y58FeSmJYtTOXDXWjCMjNj2AymPu_aac5Fk/edit

  • 4. Two successes and two improvements

  • Participants will bring a list of no more than 2 items that were done well during the project, and no more than 2
    items that could be improved upon. Limiting to 2 requires people to think critically about their experience.

  • 5. Identifying the top five

  • At the meeting, start by having each person present their items (successes, then improvements). Make a list of these
    items, and note duplicates. Based on popularity, identify the top 5 success items and the top 5 items that need
    improvement.

  • Discuss the 5 success items first. Identify specific things that can be applied to future sims. Celebrate, pat each
    other on the back. Then move on to the harder part.
  • Discuss the 5 improvement items. Try to avoid getting personal. Discuss what was learned, and identify specific things
    that can be done to prevent these problems in the future. If anything needs more investigation, assign to specific
    individuals.
  • 6. Modifications to Look & Feel
  • Identify modifications to the PhET Look-&-Feel Guidelines. If applicable, based on what we learned during development
    of this sim, suggest revisions to the guidelines.
  • 7. Sim checklist

  • Review the Sim Checklist

  • 8. Action items

  • Note important items in the postmortem GitHub issue, and create issues for any tasks the require action, such as
    updating documents, leftover TODOs, etc.

  • Action Item Questions:

    • Modifications to look and feel?
    • Modifications to sim design process?
    • Modifications to project process?
    • Messages to share at status?
  • 9. Take home messages

  • From the top 5 successes/improvements, decide what are the "take home" messages that would be useful to note in the
    future, and add these to the HTML5 Postmortem Take Home Messages Google doc

  • Report out at status meeting

@marlitas marlitas self-assigned this Nov 1, 2023
@brent-phet
Copy link

FYI - @JacquiHayes noticed the following:

Jacqui Hayes
[8:39 AM] I just downloaded the Center & Variability sim, and it is 9.6MB. That’s a really big file. Is that normal now?
[8:39] For reference, I thought our sims were ~4MB
[8:40] It’s not a huge file compared to other products, but since the sims get downloaded over mobile data in poor countries, we do try to minimize the file size.

@marlitas
Copy link
Contributor Author

I just downloaded the Center & Variability sim, and it is 9.6MB. That’s a really big file. Is that normal now?

We knew CAV was bigger than some other sims that have been published. A large part of this was the static allocation in PhET-iO that I think contributed to making the code easier to maneuver and maintain, but did result in a larger file size. This could be something to bring up during post-mortem if we're concerned about the large file size as something to consider when decided between static vs. dynamic allocation in PhET-iO sims.

@samreid
Copy link
Member

samreid commented Nov 14, 2023

Static vs dynamic allocation is not related to the HTML file size. The images directory for this sim is 10.5MB which accounts for most of the size (compared to other sims).

@marlitas
Copy link
Contributor Author

Thanks to @samreid for clarifying that in today's meeting as well as in this issue. I was unaware and made incorrect assumptions.

@samreid
Copy link
Member

samreid commented Nov 16, 2023

Regarding the file size, I opened a new issue #598 for investigation. There is an experiment that relates the file size to the png size.

@marlitas
Copy link
Contributor Author

marlitas commented Feb 9, 2024

The post-mortem for CaV was finished a while ago and file size investigation is heartily underway elsewhere. Closing.

@marlitas marlitas closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants