tsc -b failing when it should succeed

[samreid]

On slack, @jbphet said:

Did something change about our TS configuration? tsc -b just identified a bunch of untyped parameters in closure functions in Greenhouse. I've fixed them all, but I'm wondering why they are just now causing build failures.

@pixelzoom said:

Example?

I asked:

Can you run tsc -b —clean first and see if the problem disappears?

@jbphet said:

Example:
was: this.concentrationProperty.link( concentration => {
changed to: this.concentrationProperty.link( ( concentration: number ) => {

@pixelzoom said:

@jbphet if you’re referring to phetsims/greenhouse-effect@29de0dd, then it looks like you just added the kind of redundant typecheck in link calls that @samreid just removed.

@jbphet said:

Well that's not good. Why did they suddenly start coming up as build failures?

@pixelzoom said:

I don’t know. Maybe @samreid has some insight.

@jbphet said:

Maybe @samreid removed them from Greenhouse, but something local to me hadn't been updated. I'll look at the history.

@jonathanolson said:

I've had cases of errors not showing up until a clean

@pixelzoom said:

I have not pulled phetsims/greenhouse-effect@29de0dd, and tsc -b shows no errors in my working copy of greenhouse-effect.

@jbphet said:

Yep, I just undid what Sam changed because I was seeing the errors. I'll un-undo it.

@pixelzoom said:

Did you pull axon recently, to get the changes that @samreid made to link?

@jbphet said:

Yes.

I said:

Have you tried tsc -b --clean since then?
Want to zoom?

@jbphet said:

No need to zoom, I have a meeting now, but I basically did a clean and undid the changes and it looks like it's working.

I said:

Sorry about the clean bugs, it may be an occurrence of microsoft/TypeScript#46153

@jbphet said:

I've recovered and am good to go.

I replied:

I’m considering writing that up as an issue so we can refer to it as an example of the problems potentially caused by microsoft/TypeScript#46153 (edited)

[pixelzoom]

tsc -b has also been succeeding when WebStorm says it should fail.

[samreid]

We stopped using tsc -b, closing.