-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package-lock.json files getting created after updating npm version #1175
Comments
I observed this is happening with |
@mattpen or @jonathanolson can you help speculate what is happening or how to investigate it? I basically have to keep deleting package-lock.json files during a deploy which is scary. |
@mattpen said this may be fixed in a newer version of node. |
@samreid - Please check out @pixelzoom's comments in this issue: #1035. It looks like updating your node version should fix it. |
I'll reopen if there are more problems in the future, thanks! |
Still happening even for creating dev verisons. |
|
I believe that we should add in package-lock.json files to our project. This is coming from phetsims/perennial#428, but has come up quite often for the last few years. It may involve a script that goes to every branch in every repo, runs |
Note that binder and weddell currently have package-lock.json files. It's unclear whether that's intentional, or whether they were accidentally checked in. |
From conversation with @jonathanolson and @samreid Benefits:
Costs:
Notes and follow up questions:
Cases that use npm install:
Next steps: |
Today I updated npm. Build processes are failing because it keeps creating package-lock.json. Following #578 I set
npm config set save false
but it still created the files. I wanted to make RC.3 for phetsims/circuit-construction-kit-common#796 so I was deleting those files as it created them. But there is hopefully a better way.The text was updated successfully, but these errors were encountered: