Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential conflict with cookies in Edge #888

Closed
KatieWoe opened this issue Feb 24, 2020 · 18 comments
Closed

Potential conflict with cookies in Edge #888

KatieWoe opened this issue Feb 24, 2020 · 18 comments
Assignees
Labels

Comments

@KatieWoe
Copy link

Found during phetsims/qa#482, but warning comes up with published sims.
A warning that Edge will start blocking cookies without a certain marker in the future comes up when using a sim with dev tools. Unsure what bit of code this is or how it might impact sims, so investigation may be called for. This is the chromium version of Edge.
cookie

@KatieWoe
Copy link
Author

A cookie associated with a resource at (sim) was set with SameSite=None but without Secure. A future release of Microsoft Edge will only deliver cookies marked SameSite=None if they are also marked Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at (website).

@ariel-phet
Copy link
Contributor

@mattpen can you take a quick look at this - is this something on the website side with how sims are delivered, or is this something with the sim file itself? My naive impression is there is nothing about the sim file itself that would specify cookies and this is more a website/server issue?

@ariel-phet ariel-phet removed their assignment Feb 24, 2020
@jonathanolson
Copy link
Contributor

This looks more like it's related with Google Analytics (in my wheelhouse)

@mattpen
Copy link
Contributor

mattpen commented Feb 24, 2020

@KatieWoe - I can't recreate this. I see this warning for a lot of pages on our website and it isn't limited to Edge. The warning is related to GA tracking and those cookies are set by code run by google. I don't see this warning when running a sim though, either in Edge or Chrome:

image

image

@KatieWoe
Copy link
Author

I haven't seen it in chrome, but I see it in Edge. Like I said above though, I see it in chromium Edge. Your screenshot looks like the old Edge.

@zepumph
Copy link
Member

zepumph commented Feb 26, 2020

@KatieWoe
Copy link
Author

I'm using Version 80.0.361.62 (Official build) (64-bit)

@zepumph
Copy link
Member

zepumph commented Feb 26, 2020

Ahh thanks! I went and downloaded the new and improved Edge (same version as you), and now get the error immediately:

image

@mattpen
Copy link
Contributor

mattpen commented Feb 26, 2020

I'm running into Windows Update issues and can't currently install Edge 80 (stuck on 44, which is pre-chromium). Interesting that this warning doesn't appear in the latest version of Chrome, as a lot of other pages are printing similar warnings. Anyway for this page in particular, this is not website code but sim code, so moving to developer meeting per request from @ariel-phet.

@pixelzoom
Copy link
Contributor

3/5/20 dev meeting:

Related to Google analytics, so this is in @jonathanolson's wheelhouse. Assigning to him.

@mattpen
Copy link
Contributor

mattpen commented Aug 7, 2020

My windows machine currently can't upgrade to the latest version of Edge, removing assignment.

@mattpen mattpen removed their assignment Aug 7, 2020
@mattpen
Copy link
Contributor

mattpen commented Aug 17, 2020

I was able to install Edge Beta 85. This problem is not present in this version. Perhaps it is fixed?

@jonathanolson
Copy link
Contributor

I'm seeing warnings about cookies on the website itself (vimeo, google), but I'm not seeing any warnings about cookies when running simulations directly. I'm also seeing our google analytics send out properly from sims.

@KatieWoe can you see if we're getting warnings with sims with the latest Edge version? (Tested with version 84).

@KatieWoe
Copy link
Author

I'm not seeing this in the sim now. I am seeing some odd warning in the website and when launching the sim, but I don't know if they are connected.

@KatieWoe KatieWoe assigned jonathanolson and unassigned KatieWoe Aug 17, 2020
@mattpen mattpen assigned KatieWoe and unassigned jonathanolson Aug 17, 2020
@mattpen
Copy link
Contributor

mattpen commented Aug 17, 2020

@KatieWoe - Can you please provide details for "some odd warning in the website" and then assign me and @jonathanolson ?

@KatieWoe
Copy link
Author

Most were tracking prevention warnings. an error showed up and flashed quickly as you click on a link to go to a sim.
Uncaught syntax [rror: missing ) after argument list
warninganderrors

@KatieWoe KatieWoe assigned jonathanolson and mattpen and unassigned KatieWoe Aug 17, 2020
@mattpen
Copy link
Contributor

mattpen commented Aug 17, 2020

This doesn't look like it affects sims, removing @jonathanolson's assignment

@mattpen
Copy link
Contributor

mattpen commented Sep 22, 2020

https://docs.microsoft.com/en-us/microsoft-edge/web-platform/tracking-prevention

This newer message looks like a byproduct of a new feature in Edge. This is probably expected behavior. This doesn't seem to be causing any problems, so I'm going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants