Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the point of the NaN values for points? #39

Closed
jonathanolson opened this issue Aug 13, 2015 · 3 comments
Closed

What is the point of the NaN values for points? #39

jonathanolson opened this issue Aug 13, 2015 · 3 comments
Assignees

Comments

@jonathanolson
Copy link
Contributor

It seems like an anti-pattern, and I wasn't easily able to determine what they were being used for.

Review: #31

@andrey-zelenkov
Copy link
Contributor

It was necessary to determine situation when the point is outside the graph (coordinates isn't important in this case, so it's set to NaN). If NaN should be eliminated then we can calculate coordinates for every point position and add some extra checks, but imho adding description to clarify this moment can be enough.

@andrey-zelenkov
Copy link
Contributor

NaN values were removed during fixing #48 (9bbea0b). It was replaced by 'isInsideGraph' flag.

@jonathanolson
Copy link
Contributor Author

Looks good, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants