Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does include any config that was only needed for development? For example #286

Closed
Tracked by #123
samreid opened this issue Jul 29, 2024 · 1 comment
Closed
Tracked by #123

Comments

@samreid
Copy link
Member

samreid commented Jul 29, 2024

It looks like the lint rules are redundant with the chipper ones. Let's clean this up. For example:

  "eslintConfig": {
    "extends": "../chipper/eslint/sim_eslintrc.js",
    "overrides": [
      {
        "files": [
          "**/*.ts"
        ],
        "rules": {
          "@typescript-eslint/ban-ts-comment": [
            "error",
            {
              "ts-expect-error": true,
              "ts-ignore": true,
              "ts-check": true,
              "ts-nocheck": true
            }
          ]
        }
      }
    ]
  }

This is in all 4 repos.

@samreid samreid mentioned this issue Jul 29, 2024
84 tasks
@samreid
Copy link
Member Author

samreid commented Aug 6, 2024

Oh, I see that chipper has different defaults for those. I tried fixing this in chipper but there were 600+ errors. So we are in good shape for this one. Closing.

@samreid samreid closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant