Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text shifts in top banner of game level with ?stringTest=dynamic #158

Closed
Tracked by #1074
, #1075
...
pixelzoom opened this issue Apr 18, 2024 · 4 comments
Closed
Tracked by #1074
, #1075
...

Text shifts in top banner of game level with ?stringTest=dynamic #158

pixelzoom opened this issue Apr 18, 2024 · 4 comments
Labels
status:ready-for-review

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Apr 18, 2024 •
edited
Loading

For phetsims/qa#1066 and phetsims/qa#1067 ...

To be tested in the next RC, see phetsims/vegas#127.

phetsims/vegas@18b8a3d was cherry picked for graphing-lines 1.4 and graphing-slope-intercept.
@pixelzoom pixelzoom mentioned this issue Apr 18, 2024
Closed
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Apr 22, 2024 •
edited
Loading

Ready for review in GL 1.4.0-rc2 and GSI 1.2.0-rc2. Please close this issue if it tests OK.

This was referenced Apr 22, 2024
Closed
Closed
@Nancy-Salpepi
Copy link

I can no longer reproduce this issue in GL 1.4.0-rc.2 and GSI 1.2.0-rc.2.
Closing.

@KatieWoe
Copy link
Contributor

I saw maybe a bit of shift, but it was much, much better and not very noticeable. @pixelzoom let me know if you'd like this reopened, but I don't think it's necessary.

@pixelzoom
Copy link
Contributor Author

Thanks @KatieWoe. No need to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pixelzoom @KatieWoe @Nancy-Salpepi