Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving MoleculesAndLightKeyboardHelpContent to this repo and renaming #272

Open
jbphet opened this issue Feb 24, 2023 · 1 comment
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Feb 24, 2023

As of this writing, the keyboard help dialog for the Molecules and Light sim is in the molecules-and-light repo, but most of the rest of the code for that sim is in this repo (greenhouse-effect) because the planned "Micro" screen of the Greenhouse Effect sim will share most of its code with Molecules and Light. However, the design of the "Micro" screen is not complete and has been paused, and according to @kathy-phet isn't likely to get any attention soon. So, at this point, it's impossible to say whether the keyboard help dialogs for the two sims can be the same, slightly different (which could potentially be handled through parameterization), or different enough that each repo should have its own version. Once work on the "Micro" screen resumes, we should sort this out.

@jbphet jbphet self-assigned this Feb 24, 2023
@jbphet
Copy link
Contributor Author

jbphet commented Feb 24, 2023

Deferring until work on the "Micro" screen resumes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant