Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the numbers entered in the keyboard be stateful? #315

Closed
KatieWoe opened this issue Dec 7, 2023 · 3 comments
Closed

Should the numbers entered in the keyboard be stateful? #315

KatieWoe opened this issue Dec 7, 2023 · 3 comments
Assignees
Labels
type:bug Something isn't working type:wontfix This will not be worked on

Comments

@KatieWoe
Copy link

KatieWoe commented Dec 7, 2023

Test device
iPad
Operating System
iPadOS 17
Browser
Safari
Problem description
For phetsims/qa#1008
The keypad for changing mass or other properties of the bodies is stateful in if it is open or not. Any numbers being entered are not stateful. If you press enter the new data is captured in state. If this is intended, feel free to close

Visuals
numstate

@KatieWoe KatieWoe added the type:bug Something isn't working label Dec 7, 2023
@AgustinVallejo
Copy link
Contributor

@pixelzoom Is this a common code issue or should we take a look into it?

@pixelzoom
Copy link
Contributor

Good question @KatieWoe!

Keypad statefulness is still not supported in common code, see phetsims/scenery-phet#540.

And for the 1.3 release of this sim, we specifically punted - see #234 (comment). The only requirement is that the PhET-iO API needs to include keypadDialog.isShowingProperty, and we've done that.

So closing this issue as "won't fix". @arouinfar @kathy-phet FYI.

@pixelzoom pixelzoom added the type:wontfix This will not be worked on label Dec 7, 2023
@pixelzoom
Copy link
Contributor

pixelzoom commented Dec 7, 2023

See also #293 (comment), where I noted this specific issue while testing the Standard Wrapper:

As with the State wrapper (see #289 (comment)), the initial state of KeypadDialog is incorrect in the Standard wrapper. See screenshot below, where the range and value are both missing. But that is to be expected, since we punted on instrumenting KeypadDialog and Keypad (see #234). And in practice there is no reason to create a wrapper where the initial state has the KeypadDialog open.

screenshot_2894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working type:wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants