PDOM order seems to change as you interact with kittens

[marlitas]

While meeting with @catherinecarter and @terracoda we noticed that the kittens' tab order seemed to constantly be changing based on the interaction.

Screen.Recording.2024-11-01.at.12.34.34.PM.mov

To Reproduce

1. tab to the first kitten
2. move it with arrow keys
3. tab again (you exit the kittens completely)

We should still have remaining kittens to tab through.

I would like @jessegreenberg's help on this since I am not aware of how the PDOM determines order.

[jessegreenberg]

The default traversal order comes from the order in the scene graph. If there is a moveToFront somewhere it will impact the traversal order. After moveToFront, the kitten will be the last item in the parent's children order, and also the last item in the parent's traversal order.

This can be fixed by setting an explicit pdomOrder on the parent of the kittens so the moveToFront doesn't change it.

[marlitas]

@jessegreenberg oh that's definitely it then. Thanks so much!