Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make accessibleNameBehavior work without a tagName #1664

Closed
jessegreenberg opened this issue Oct 27, 2024 · 2 comments
Closed

Make accessibleNameBehavior work without a tagName #1664

jessegreenberg opened this issue Oct 27, 2024 · 2 comments
Assignees

Comments

@jessegreenberg
Copy link
Contributor

From phetsims/scenery-phet#880, I found that accessibleNameBehavior only works if you specify a tagName.

For many use cases, accessibleNameBehavior will be useful for forwarding the accessibleName to a subcomponent, where the parent component should not have any PDOM content.

If accessibleNameBehavior can work without a tagName it will save the PDOM from having lots of extra divs and developers from spending time trying to figure out why accessibleNameBehavior isn't working.

@jessegreenberg
Copy link
Contributor Author

This won't be simple. Accessibility in scenery has always assumed that tagName is the 'entry point' for all ParallelDOM options.

@jessegreenberg
Copy link
Contributor Author

This change is too large, so I am going to close. Instead, I made some helper functions for forwarding the accessible Name and using those will set a default tagName, see #1665. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant