Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccessibleSlider options #358

Closed
jonathanolson opened this issue May 14, 2018 · 4 comments
Closed

AccessibleSlider options #358

jonathanolson opened this issue May 14, 2018 · 4 comments
Assignees

Comments

@jonathanolson
Copy link
Contributor

Can initializeAccessibleSlider's options be changed somehow so we can specify a label and description?

Right now, I need to call initializeAccessibleSlider, and then manually mutate the labelTagName/labelContent/descriptionContent afterwards (in ProportionalPartitionLineNode).

For abstraction, should we have a field for the label and description (so if the implementation changes, we don't have to change client call-sites)?

@zepumph
Copy link
Member

zepumph commented May 26, 2018

I'm tempted to hold off on this until we settle out and implement phetsims/scenery#795.

@zepumph zepumph removed their assignment Jul 17, 2018
@jessegreenberg
Copy link
Contributor

We should go ahead and add these options in the meantime while we continue to work on phetsims/scenery#795. @jessegreenberg will work on this.

@marlitas
Copy link
Contributor

marlitas commented Nov 5, 2024

Meeting 11/5

  • @jessegreenberg is going to determine wether this is stale or not and close if it is.

@jessegreenberg
Copy link
Contributor

This is stale (I believe after improvements were made to the trait/mixin pattern but not sure). You can pass these options directly to the super call, and there isn't a initializeAccessibleSlider anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants