Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can ComboBox get better tests? #867

Closed
zepumph opened this issue Jan 2, 2024 · 1 comment
Closed

Can ComboBox get better tests? #867

zepumph opened this issue Jan 2, 2024 · 1 comment
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Jan 2, 2024

There were multiple bugs that came in related to PhET-iO + other features of Combo box (alt input and sound).

#859
#861
#862
#864

I would like to spend a few minutes trying to brainstorm how we may be able to write tests to help catch this kind of thing for our common code moving forward. @samreid, I'm implicating you for a 15 minute brainstorm (sorry).

This is also coming from https://github.com/phetsims/phet-io-wrappers/issues/632

@zepumph
Copy link
Member Author

zepumph commented Jan 2, 2024

@samreid and I discussed this, and determined that we should focus on https://github.com/phetsims/phet-io/issues/1889 and ensuring that QA and devs are well set up to know important things to test, especially as new things come up like this. Closing

@zepumph zepumph closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants