Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tier 1 Voicing features #108

Open
jessegreenberg opened this issue Dec 5, 2024 · 3 comments
Open

Add tier 1 Voicing features #108

jessegreenberg opened this issue Dec 5, 2024 · 3 comments

Comments

@jessegreenberg
Copy link
Contributor

For #98 , we would like to try adding Tier 1 Voicing as part of that release. According to a design doc template, that includes:

  • Voicing Name Responses for all interactive objects. (Relationship to Interactive Description: Ideally same as Accessible Names)
  • Voicing Hint Responses for all interactive objects. (Relationship to Interactive Description: Same or brief versions of Help text descriptions). Note: Delivery is input specific.
  • Voicing Play Overview (available from Voicing Toolbar). (Relationship to Interactive Description: Equivalent to Sim Overview, must not refer to Play Area or Control Area.)
  • Voicing Play Details (available from Voicing Toolbar). (Relationship to Interactive Description: Ideally equivalent to Current Details.)

In addition to common code work to support UI components, we will need to consider how "Tier 1" should be introduced in the Preferences dialog, and Voicing toolbar. See phetsims/joist#995.

@jessegreenberg
Copy link
Contributor Author

I enabled Voicing in this sim (did not commit). We will need voicing name and hint responses for Checkbox, AquaRadioButton, and AccordionBox/ExpandCollapseButton (in addition to the above).

AquaRadioButton supports voicing but not a name respons. I found this comment in quadrilateral ,which is the last place we looked at Voicing:

    // Voice the radio button on selection. We considered putting this in AquaRadioButton, but the design
    // team indicated different radio buttons might voice different content (not just the name response).
    soundDesignRadioButtonGroup.onInputEmitter.addListener( () => {
      soundDesignRadioButtonGroup.getButton( model.soundDesignProperty.value ).voicingSpeakNameResponse();
    } );

@jessegreenberg
Copy link
Contributor Author

jessegreenberg commented Dec 13, 2024

I took a look at the design document so far, and I have some questions about Voicing.

  • How is Voicing going to behave in Preferences with "Tier 1" release? Do we need to redesign that section in the Preferences dialog?
  • Can the the "Overview Sections" for Tier 1 description and Tier 1 Voicing be made the same? It seems unfortunate that every sim going to have these (mostly) duplicated paragraphs of translatable strings.
  • The "current details" says it should be the same as the Interactive Description content, but how would Voicing read out the list?
  • Is there supposed to be a "Boilerplate intro" for Voicing? I don't think I have seen this before, when is it spoken?
  • The "current details" has a list of information. Is that in scope for tier 1 (Voicing AND description)?
  • Just noting that the expanded content for the values accordion box is going to be called accessibleParagraph instead of helpText after ParallelDOM: New high level API for descriptive text scenery#1673.
  • Why does the current details list need to be shown twice in the PDOM (once in the accordion box and once in the details section)?
  • The design document describes a Voicing Name Response for the Angle Units radio button group. I am not sure how that would work, Voicing would only support a voicingNameResponse on each button.

@jessegreenberg
Copy link
Contributor Author

How is Voicing going to behave in Preferences with "Tier 1" release? Do we need to redesign that section in the Preferences dialog?

See phetsims/joist#1002

Can the the "Overview Sections" for Tier 1 description and Tier 1 Voicing be made the same? It seems unfortunate that every sim going to have these (mostly) duplicated paragraphs of translatable strings.

We are going to try an approach where the strings are the same. In common code, the summary content is prefix with "The Play Area: {} ", as a way to reuse the same strings. See phetsims/joist#995.

Is there supposed to be a "Boilerplate intro" for Voicing? I don't think I have seen this before, when is it spoken?

During discussion we decided that this content is not necessary for Voicing contexts.

Why does the current details list need to be shown twice in the PDOM (once in the accordion box and once in the details section)?

It is intentional and necessary.

The design document describes a Voicing Name Response for the Angle Units radio button group.

Groups generally do not have a voicingNameResponse, this can be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant