-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tier 1 Voicing features #108
Comments
I enabled Voicing in this sim (did not commit). We will need voicing name and hint responses for Checkbox, AquaRadioButton, and AccordionBox/ExpandCollapseButton (in addition to the above). AquaRadioButton supports voicing but not a name respons. I found this comment in quadrilateral ,which is the last place we looked at Voicing: // Voice the radio button on selection. We considered putting this in AquaRadioButton, but the design
// team indicated different radio buttons might voice different content (not just the name response).
soundDesignRadioButtonGroup.onInputEmitter.addListener( () => {
soundDesignRadioButtonGroup.getButton( model.soundDesignProperty.value ).voicingSpeakNameResponse();
} ); |
I took a look at the design document so far, and I have some questions about Voicing.
|
We are going to try an approach where the strings are the same. In common code, the summary content is prefix with "The Play Area: {} ", as a way to reuse the same strings. See phetsims/joist#995.
During discussion we decided that this content is not necessary for Voicing contexts.
It is intentional and necessary.
Groups generally do not have a voicingNameResponse, this can be ignored. |
For #98 , we would like to try adding Tier 1 Voicing as part of that release. According to a design doc template, that includes:
In addition to common code work to support UI components, we will need to consider how "Tier 1" should be introduced in the Preferences dialog, and Voicing toolbar. See phetsims/joist#995.
The text was updated successfully, but these errors were encountered: