Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gemini agent #1912

Merged
merged 3 commits into from
Jan 30, 2025
Merged

fix: gemini agent #1912

merged 3 commits into from
Jan 30, 2025

Conversation

anuragts
Copy link
Contributor

Description

Added agent id to gemini agent

Made agent id optional

Fixes # (issue)

Type of change

Please check the options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Model update
  • Infrastructure change

Checklist

  • My code follows Phidata's style guidelines and best practices
  • I have performed a self-review of my code
  • I have added docstrings and comments for complex logic
  • My changes generate no new warnings or errors
  • I have added cookbook examples for my new addition (if needed)
  • I have updated requirements.txt/pyproject.toml (if needed)
  • I have verified my changes in a clean environment

Additional Notes

Include any deployment notes, performance implications, or other relevant information:

dirkbrnd
dirkbrnd reviewed Jan 29, 2025
View reviewed changes
libs/agno/agno/playground/sync_router.py Outdated
@@ -68,7 +68,7 @@ def get_agents():

agent_list.append(
AgentGetResponse(
agent_id=agent.agent_id,
agent_id=agent.agent_id if agent.agent_id else None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary?

dirkbrnd
dirkbrnd reviewed Jan 29, 2025
View reviewed changes
libs/agno/agno/playground/async_router.py Outdated
@@ -73,7 +73,7 @@ async def get_agents():

agent_list.append(
AgentGetResponse(
agent_id=agent.agent_id,
agent_id=agent.agent_id if agent.agent_id else None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary

manthanguptaa
manthanguptaa reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@manthanguptaa manthanguptaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after @dirkbrnd's comments are resolved

@dirkbrnd dirkbrnd merged commit 19f5e8d into refactor/agno Jan 30, 2025
1 check passed
@dirkbrnd dirkbrnd deleted the fix/gemini-agent branch January 30, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manthanguptaa manthanguptaa manthanguptaa left review comments

@dirkbrnd dirkbrnd dirkbrnd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anuragts @manthanguptaa @dirkbrnd