Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename panic_implementation attribute to panic_handler #465

Closed
nasherm opened this issue Sep 23, 2018 · 3 comments
Closed

Rename panic_implementation attribute to panic_handler #465

nasherm opened this issue Sep 23, 2018 · 3 comments

Comments

@nasherm
Copy link

nasherm commented Sep 23, 2018

The panic_implementation attribute has been deprecated for RFC 2070 and renamed to panic_handler
@Ben-PH
Copy link
Contributor

Ben-PH commented Sep 27, 2018

Forking now. I ran into this and didn't think to put the issue up. I'm getting a lot of value out of this, will feel good to contribute.

@Ben-PH
Copy link
Contributor

Ben-PH commented Sep 27, 2018 •
edited
Loading

found the pull-request

deprecating panic_implementation

@Ben-PH Ben-PH mentioned this issue Sep 27, 2018
Merged
@phil-opp
Copy link
Owner

phil-opp commented Oct 1, 2018

Fixed in #467. Thanks for reporting @TuringDisciple!

@phil-opp phil-opp closed this as completed Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@phil-opp @Ben-PH @nasherm