Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a spinner (whatever) while loading #121

Open
dimateos opened this issue Nov 28, 2024 · 0 comments
Open

Show a spinner (whatever) while loading #121

dimateos opened this issue Nov 28, 2024 · 0 comments

Comments

@dimateos
Copy link
Contributor

The list/graph of commits should be discarded/hidden when a new list/graph is being loaded.
Should also show a placeholder loader spinner or something, but at the very least discard the shown ones:

In the following GIF the loading is fast but sometimes (e.g. large repo or workspace startup) it can take several seconds where the combo box shows the newly selected repo WITH the commits/graph from the previous.

Actually, you can scroll and select commits from the previous while the new is yet to be loaded and then you get these popup errors:
image

2024-11-28_(134608)_Code
^ In this case I only show the graph for privacy, and you can only see the loading spinner from mhutchie.git-graph for a split second

There could be an option to toggle this in case users want to avoid the empty view popping between loads. IMO not worth the effort and this should be forced as the current behavior can leads to the mentioned errors.

Not high priority, but good UX improvement and avoids edge case errors.


Related to initial repo info queries mentioned in #93 and extending to #71
The current issue is about every time the graph for a specific repo is requested, but I guess if there is a placeholder while loading then:

  • Use it at the initial load too, not only when switching between repos (discarding current graph)
    • Similar to top-right reload button rotation
  • Here the spinner/loader could transition to X error when there are issues, instead of popups (but complementing console/log errors)
    • When the error is about empty repo/not loaded yet, hint the user to "Refresh" to retry
    • NOTE:: in the current issues mentioned the view is empty forever and the user cannot "Refresh" (even the button is spinning constantly)

Regards! many times today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant