Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should domains have favicons shown in the vomnibar? #1208

Closed
philc opened this issue Oct 29, 2014 · 4 comments
Closed

Should domains have favicons shown in the vomnibar? #1208

philc opened this issue Oct 29, 2014 · 4 comments

Comments

@philc
Copy link
Owner

philc commented Oct 29, 2014

image

@dragon788
Copy link

Does this still need some security auditing? I do like the idea of a favicon, sometimes sites like to masquerade with a false favicon, but its an easy way to distinguish between them.

@mrmr1993
Copy link
Contributor

mrmr1993 commented May 9, 2015

So far I think we've tried a couple of things but rejected them:

Realistically, we need a new way to get favicon URLs before we try this again.

@smblott-github
Copy link
Collaborator

An alternative would be to have icons in the vomnibar to indicate the type of the suggestion, as chrome does...

snapshot

The current text-based approach looks pretty clunky, IMHO.

@smblott-github
Copy link
Collaborator

We've rejected this idea, for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants