Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text colour is wrong #3940

Closed
0WN463 opened this issue Oct 19, 2021 · 3 comments
Closed

Text colour is wrong #3940

0WN463 opened this issue Oct 19, 2021 · 3 comments

Comments

@0WN463
Copy link

0WN463 commented Oct 19, 2021

Describe the bug
When using lint hints on certain sites, the colour of the text is wrong.

image

This issue occurred after I upgraded Chromium
This issue is not present when I use LibreWolf

Sites with issue: YouTube
Sites without issue: GitHub

It seems like the CSS are not being applied properly, cause on other sites, my custom BG colour for the hints are applied
It also seems like this also somehow affects the extension dialog itself

image

Solutions attempted:

  1. Clearing cache
  2. Turning off DarkReader
  3. Turning off Dark Mode on the site

To Reproduce

  1. Go to any of the sites
  2. Activate Link Hints

Browser and Vimium version

If you're using Chrome, include the Chrome and OSS version found at chrome://version. Also include the Vimium version found at chrome://extensions.

Chromium | 94.0.4606.81 (Official Build) Arch Linux (64-bit)
-- | --
Revision | 5a03c5f1033171d5ee1671d219a59e29cf75e054-refs/branch-heads/4606@{#1320}
OS | Linux
JavaScript | V8 9.4.146.21
User agent | Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.81 Safari/537.36
Command Line | /usr/lib/chromium/chromium --enable-crashpad --flag-switches-begin --enable-features=WebContentsForceDark:increase_text_contrast/true --flag-switches-end
Description
The Hacker's Browser. Vimium provides keyboard shortcuts for navigation and control in the spirit of Vim.
Version
1.67
@gdh1995
Copy link
Contributor

gdh1995 commented Oct 20, 2021

It's a limitation of Chrome's #enable-force-dark flag , and there's a working around in https://github.com/gdh1995/vimium-c/wiki/Style-the-UI-of-Vimium-C-using-Custom-CSS#work-with-enable-force-dark (you need to replace CSS selectors in it with Vimium's)

@0WN463
Copy link
Author

0WN463 commented Oct 20, 2021

Strange that it only applies on certain sites though.
Just applying the CSS was not enough, I have to spam a lot of !important then it work.
Thanks anyways!

@0WN463 0WN463 closed this as completed Oct 20, 2021
@gdh1995
Copy link
Contributor

gdh1995 commented Oct 21, 2021

Um, I think it's because DarkReader might override some of your custom CSS. If you only enable #enable-force-dark, then !important should work on a top frame; while on a child iframe, then there's a related bug affecting CSS for LinkHints UI: #3883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants